Fix node.cmd white space paths #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paths with blanks for the node command are note processed correctly (see nyc)
bcoe
requested changes
Sep 29, 2017
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "spawn-wrap", | |||
| "version": "1.3.4", | |||
| "version": "1.3.5-a", | |||
There was a problem hiding this comment.
no need to bump the version, we can do this when we release the update.
| @@ -150,11 +150,15 @@ function mungeCmd (workingDir, options) { | |||
|
|
|||
| var m = command.match(re) | |||
| var replace | |||
| var nodeCmd = workingDir + '/node.cmd' | |||
There was a problem hiding this comment.
this should probably be \\node.cmd?
There was a problem hiding this comment.
Not necessarily. afaik, JS on windows can parse "/" paths properly. One can use e.g. the "path" package:
var path = require("path");
var absolutePath = path.resolve("Relative file path");
| @@ -150,11 +150,15 @@ function mungeCmd (workingDir, options) { | |||
|
|
|||
| var m = command.match(re) | |||
| var replace | |||
| var nodeCmd = workingDir + '/node.cmd' | |||
| if(workingDir.indexOf(' ') !== -1) { | |||
| nodeCmd = ' "' + nodeCmd + '"' | |||
There was a problem hiding this comment.
any reason to not just always wrap the nodeCmd in quotes for Windows?
There was a problem hiding this comment.
Correct. I don't think there are side-effects.
|
What's the status of this? Seems like this should fix #69, which currently prevents me from getting coverage with |
|
I believe this issue has been addressed by other PR's for the 2.x release line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If node.cmd is in a path with white spaces (e.g. nyc run on windows where the user home has a space in it), the command fails with ENOENT. This should fix it.